Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use batch_alter_table to drop column in the migration script #406

Merged
merged 1 commit into from
Apr 30, 2016

Conversation

x4base
Copy link
Contributor

@x4base x4base commented Apr 28, 2016

Should we use render_as_batch=True in context.configure in migrations/env.py as well?

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling cb3a531 on x4base:batch_alter_table into bd47a29 on airbnb:master.

@coveralls
Copy link

coveralls commented Apr 28, 2016

Coverage Status

Coverage remained the same at 80.986% when pulling cb3a531 on x4base:batch_alter_table into bd47a29 on airbnb:master.

@mistercrunch
Copy link
Member

I don't feel strongly about that, but we may want to have a unit test that tests downgrades. We probably want to also setup travis builds on different databases (sqlite, mysql, postgres) eventually.

@mistercrunch
Copy link
Member

I read the docs about render_as_batch here:
http://alembic.readthedocs.io/en/latest/batch.html
and it seems reasonable, I'd approve in a PR that adds downgrading tests that go all the way, provided that this new test also works on my local MySQL.

@x4base
Copy link
Contributor Author

x4base commented Apr 29, 2016

So I should add the downgrading tests here, right?

@mistercrunch
Copy link
Member

This is fine as is, I'll merge.

In the future we should probably test downgrades on multiple databases in Travis.

@mistercrunch mistercrunch merged commit 7b5b602 into apache:master Apr 30, 2016
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants