Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deck_multi to pass down filters to layers #4270

Merged
merged 1 commit into from Jan 25, 2018
Merged

deck_multi to pass down filters to layers #4270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 18 additions & 3 deletions superset/assets/visualizations/deckgl/multi.jsx
View file
Open in desktop
Expand Up @@ -32,11 +32,26 @@ function deckMulti(slice, payload, setControlValue) {
};
render();
payload.data.slices.forEach((subslice) => {
const url = getExploreUrl(subslice.form_data, 'json');
// Filters applied to multi_deck are passed down to underlying charts
// note that dashboard contextual information (filter_immune_slices and such) aren't
// taken into consideration here
let filters = subslice.form_data.filters.concat(fd.filters);
if (fd.extra_filters) {
filters = filters.concat(fd.extra_filters);
}
const subsliceCopy = {
...subslice,
form_data: {
...subslice.form_data,
filters,
},
};

const url = getExploreUrl(subsliceCopy.form_data, 'json');
$.get(url, (data) => {
// Late import to avoid circular deps
const layer = layerGenerators[subslice.form_data.viz_type](subslice.form_data, data);
slice.subSlicesLayers[subslice.slice_id] = layer; // eslint-disable-line no-param-reassign
const layer = layerGenerators[subsliceCopy.form_data.viz_type](subsliceCopy.form_data, data);
slice.subSlicesLayers[subsliceCopy.slice_id] = layer; // eslint-disable-line no-param-reassign
render();
});
});
Expand Down