Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetric tweaks in the CRUD list view #458

Merged
merged 1 commit into from
May 12, 2016

Conversation

mistercrunch
Copy link
Member

@williaster @georgeke
This was bugging me as sometimes the date would wrap in the middle in the list view. For the record the @renders decorator is provided by FAB (flask appbuilder) and allows to define a property for rendering a field. It's better than @property (which also works), because the sort options in the list views work and are bound to the field defined in @renders

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling e23dd9a on mistercrunch:tweaks into 6c333d5 on airbnb:master.

@coveralls
Copy link

coveralls commented May 11, 2016

Coverage Status

Coverage decreased (-0.02%) to 81.605% when pulling e23dd9a on mistercrunch:tweaks into 6c333d5 on airbnb:master.

@mistercrunch
Copy link
Member Author

SImple & low risk, merging.

@mistercrunch mistercrunch merged commit f28c2b2 into apache:master May 12, 2016
@mistercrunch mistercrunch deleted the tweaks branch May 12, 2016 04:05
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants