Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore] forcing .1% number format when using 'Period Ratio' #4774

Merged
merged 1 commit into from
Apr 9, 2018

Conversation

mistercrunch
Copy link
Member

screen shot 2018-04-05 at 11 28 24 pm

@codecov-io
Copy link

codecov-io commented Apr 6, 2018

Codecov Report

Merging #4774 into master will decrease coverage by 0.02%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4774      +/-   ##
==========================================
- Coverage   72.59%   72.57%   -0.03%     
==========================================
  Files         205      205              
  Lines       15401    15407       +6     
  Branches     1183     1189       +6     
==========================================
+ Hits        11180    11181       +1     
- Misses       4218     4223       +5     
  Partials        3        3
Impacted Files Coverage Δ
...ipts/explore/components/controls/SelectControl.jsx 84.74% <ø> (ø) ⬆️
...set/assets/javascripts/explore/stores/controls.jsx 38.12% <0%> (-1.13%) ⬇️
...s/javascripts/explore/components/ControlHeader.jsx 73.52% <50%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92230b8...0896a8d. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mistercrunch, can you give more context here? Is there no reason to have a different format when using "Period Ratio"?

@mistercrunch
Copy link
Member Author

Oh the idea is that when using a period ratio, we're looking at a % change, so we should change the format should reflect that. Since we know it's a percentage we can just format it on their behalf.

There's no precedent into cascading control changes based on rules, here we just force the format to be .1%.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, sounds and looks good!

@mistercrunch mistercrunch merged commit 9bbe50f into apache:master Apr 9, 2018
@mistercrunch mistercrunch deleted the perc branch April 9, 2018 21:02
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Apr 11, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants