[CRUD] disable user change slices from dashboardmodelview #5217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superset/views/core.py
Outdated
| @@ -554,11 +554,6 @@ class DashboardModelView(SupersetModelView, DeleteMixin): # noqa | |||
| 'want to alter specific parameters.'), | |||
| 'owners': _('Owners is a list of users who can alter the dashboard.'), | |||
| } | |||
| base_filters = [['slice', DashboardFilter, lambda: []]] | |||
There was a problem hiding this comment.
I think this is the way we make sure people see only the dashboards they have access to.
graceguo-supercat
force-pushed
the
gg-DisableChartsFromDashboardModelView
branch
from
6fa059d
to
61540b6
Compare
|
sorry for the mistake, i just want to remove select2 related filters. thank you! |
|
LGTM |
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Jun 18, 2018
(cherry picked from commit 480ddfc)
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to #5136, disable charts dropdown list (and filter function call) from dashboardmodelview, to improve the page load time for dashboard metadata edit page. Also for dashboard v2, we want to see user add/remove charts from dashboard builder as much as possible.
@michellethomas @mistercrunch @john-bodley