Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix time filter in dashboard v2 #5412

Merged
merged 1 commit into from Jul 17, 2018
Merged

Fix time filter in dashboard v2 #5412

merged 1 commit into from Jul 17, 2018

Conversation

betodealmeida
Copy link
Member

@codecov-io
Copy link

codecov-io commented Jul 17, 2018 •
edited

Codecov Report

Merging #5412 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5412   +/-   ##
=======================================
  Coverage   61.21%   61.21%           
=======================================
  Files         373      373           
  Lines       23709    23709           
  Branches     2750     2750           
=======================================
  Hits        14513    14513           
  Misses       9181     9181           
  Partials       15       15
Impacted Files Coverage Δ
...et/assets/src/dashboard/reducers/dashboardState.js 94.59% <ø> (ø) ⬆️
.../explore/components/controls/DateFilterControl.jsx 60.55% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4e6c7...40e5788. Read the comment docs.

@mistercrunch mistercrunch merged commit 75cf5e1 into apache:master Jul 17, 2018
@mistercrunch mistercrunch deleted the fix_time_filter_dash branch July 17, 2018 20:38
mistercrunch added a commit that referenced this pull request Jul 17, 2018
@mistercrunch
Revert "Fix time filter in dashboard v2 (#5412)"
90c2148 
This reverts commit 75cf5e1.
@mistercrunch mistercrunch mentioned this pull request Jul 17, 2018
Closed
@betodealmeida betodealmeida mentioned this pull request Jul 18, 2018
Closed
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
@betodealmeida @timifasubaa
Fix time filter in dashboard v2 (apache#5412)
9fabc04
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@betodealmeida @mistercrunch
Fix time filter in dashboard v2 (apache#5412)
04d9a1a
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@betodealmeida @codecov-io @mistercrunch