Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[migration] bug fix in dashboard migration (bebcf3fed1fe_) #5497

Merged
merged 1 commit into from Jul 26, 2018

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Jul 26, 2018

fix a bug in handle empty rows.

@john-bodley @michellethomas @timifasubaa

@codecov-io
Copy link

codecov-io commented Jul 26, 2018

Codecov Report

Merging #5497 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5497   +/-   ##
=======================================
  Coverage   63.33%   63.33%           
=======================================
  Files         349      349           
  Lines       22099    22099           
  Branches     2455     2455           
=======================================
  Hits        13996    13996           
  Misses       8089     8089           
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df82d9...fa4ffc8. Read the comment docs.

@mistercrunch
Copy link
Member

LGTM

@graceguo-supercat graceguo-supercat merged commit 7ff02c0 into master Jul 26, 2018
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Jul 26, 2018
fix a bug in handle empty rows

(cherry picked from commit 7ff02c0)
@graceguo-supercat graceguo-supercat deleted the gg-FixDashMigrationBug branch August 1, 2018 19:21
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants