make access request open new tab #5859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timifasubaa
force-pushed
the
open_new_tab_on_access_request
branch
2 times, most recently
from
c41144a
to
20fe7e0
Compare
timifasubaa
force-pushed
the
open_new_tab_on_access_request
branch
from
20fe7e0
to
5a4f201
Compare
timifasubaa
force-pushed
the
open_new_tab_on_access_request
branch
from
48a8787
to
bcdb849
Compare
Codecov Report
@@ Coverage Diff @@
## master #5859 +/- ##
===========================================
- Coverage 77.99% 63.73% -14.26%
===========================================
Files 46 374 +328
Lines 9312 23325 +14013
Branches 0 2607 +2607
===========================================
+ Hits 7263 14867 +7604
- Misses 2049 8445 +6396
- Partials 0 13 +13
Continue to review full report at Codecov.
|
timifasubaa
added a commit
to airbnb/superset-fork
that referenced
this pull request
Sep 13, 2018
* make access request open new tab * trigger build (cherry picked from commit 01212c3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* make access request open new tab * trigger build
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* make access request open new tab * trigger build
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes request access links open a new tab, as opposed to changing the page from Superset.
@graceguo-supercat @michellethomas