Revert old precision formatters #6056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert commit apache@66fcf9b#diff-366fb3d6e52b5fb2b9c306763adbc983 It caused sunburst to became confusing.
Codecov Report
@@ Coverage Diff @@
## master #6056 +/- ##
=========================================
+ Coverage 77.74% 77.85% +0.1%
=========================================
Files 46 46
Lines 9400 9400
=========================================
+ Hits 7308 7318 +10
+ Misses 2092 2082 -10
Continue to review full report at Codecov.
|
|
@williaster tagging you since it was part of one or your larger PRs. |
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
Revert commit apache@66fcf9b#diff-366fb3d6e52b5fb2b9c306763adbc983 It caused sunburst to became confusing.
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
Revert commit apache@66fcf9b#diff-366fb3d6e52b5fb2b9c306763adbc983 It caused sunburst to became confusing.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert commit 66fcf9b#diff-366fb3d6e52b5fb2b9c306763adbc983
It caused sunburst to became confusing.
Eg. in following visualizations:
As you can see the visualization has label 100% of the parent but you can clearly see it's not 100%