Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Migrate from Mocha+Chai to Jest #6079

Merged
merged 8 commits into from
Oct 15, 2018

Commits on Oct 12, 2018

  1. [refactor] Migrate from Mocha+Chai to Jest

    This change migrates all the existing unit tests
    - to Jest's global expect and matchers from chai's imported expect, asserts and matchers.
    - to Jest's describe/test from mocha's describe/it
    
    The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks:
    1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank.
    2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :)
    
    This change also removes dependencies to Mocha and Chai.
    xtinec committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    aeb5eb0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5fffcf3 View commit details
    Browse the repository at this point in the history
  3. Fixing lint errors. The diff looks large but is large done through `y…

    …arn run lint --fix`
    
    The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest.
    xtinec committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    632f92c View commit details
    Browse the repository at this point in the history
  4. Adding eslint-plugin-jest and further modify tests.

    - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing.
    - Deletion of a duplicated test caught by eslint-plugin-jest.
    xtinec committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    4606334 View commit details
    Browse the repository at this point in the history
  5. - Make istanbul coverage work with Jest.

    - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes!
    xtinec committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    3437946 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b768f36 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c4fc33c View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2018

  1. - tweaking maxworkers for travis and specifying coverageDirectory for…

    … codecov
    
    - remove dynamic import in shim.js now that it is set in babelrc for tests only.
    xtinec committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    1dfe55f View commit details
    Browse the repository at this point in the history