Remove isNumeric util function and use Number.isFinite instead

[kristw]

The current isNumeric() function checks if the value is not NaN, Infinity nor -Infinity.

• This function is only used in one file
• It has unclear name (Infinity and -Infinity are usually considered Number)
• It can be easily replaced with native function Number.isFinite()

Number.isFinite(Infinity);  // false
Number.isFinite(NaN);       // false
Number.isFinite(-Infinity); // false

Number.isFinite(0);         // true
Number.isFinite(2e64);      // true

Number.isFinite('0');       // false, would've been true with
                            // global isFinite('0')
Number.isFinite(null);      // false, would've been true with
                            // global isFinite(null)

@graceguo-supercat @williaster @conglei @michellethomas

[codecov-io]

Codecov Report

Merging #6106 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6106   +/-   ##
=======================================
  Coverage   77.28%   77.28%           
=======================================
  Files          47       47           
  Lines        9332     9332           
=======================================
  Hits         7212     7212           
  Misses       2120     2120

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ce1b2...4564c9b. Read the comment docs.

[williaster]

nice find 🏆 LGTM