Better support for Druid cardinality estimation mertics #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axeisghost
changed the title
|
The coverage decreased seems because the test cases do not include any column of hyperUnique or thetaSketch, so the branches in the change were not touched. |
|
Neat! |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default Druid aggregators include some aggregation operation in ingestion time that works specified for cardinality estimation. hyperUnique and thetaSketch are two aggregations that are already included in Druid package. They will create two metric columns after ingestion and we want caravel automatically add the count_distinct metric by using these two kinds of metrics for our users.
The change keeps the original logic for
is_count_distinctcolumn, but for hyperUnique and thetaSketch columns, it will setis_count_distinctto true when refreshing metadata and the metric for those columns will be automatically generated with the corresponding aggregator JSON.Some screen shots for this feature applying on wikiticker database:
The columns after refreshing wikiticker's metadata. hyperUnique and thetaSketch columns are marked as count_distinct columns.
The metrics generated from those columns.