Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying custom width for logo #6739

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Conversation

betodealmeida
Copy link
Member

We currently allow user to specify a custom logo for Superset, but the width is fixed at 126 pixels. I added an option to specify a different width in config.py.

@betodealmeida
Copy link
Member Author

cc: @xtinec

@codecov-io
Copy link

Codecov Report

Merging #6739 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6739      +/-   ##
=========================================
+ Coverage    56.1%   56.1%   +<.01%     
=========================================
  Files         521     521              
  Lines       23195   23196       +1     
  Branches     2777    2777              
=========================================
+ Hits        13014   13015       +1     
  Misses       9772    9772              
  Partials      409     409
Impacted Files Coverage Δ
superset/config.py 93.5% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fece0d...2b323e8. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #6739 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6739      +/-   ##
=========================================
+ Coverage    56.1%   56.1%   +<.01%     
=========================================
  Files         521     521              
  Lines       23195   23196       +1     
  Branches     2777    2777              
=========================================
+ Hits        13014   13015       +1     
  Misses       9772    9772              
  Partials      409     409
Impacted Files Coverage Δ
superset/config.py 93.5% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fece0d...2b323e8. Read the comment docs.

@kristw
Copy link
Contributor

kristw commented Jan 22, 2019

@betodealmeida I updated CONTRIBUTING.md with how to use labels. Could you take a quick look? #6701

@betodealmeida betodealmeida added the enhancement:request Enhancement request submitted by anyone from the community label Jan 22, 2019
@betodealmeida
Copy link
Member Author

@kristw taking a look. Sorry, I missed that discussion.

@betodealmeida betodealmeida merged commit cf1a35b into apache:master Jan 22, 2019
@betodealmeida betodealmeida added the lyft Related to Lyft label Jan 22, 2019
xtinec pushed a commit that referenced this pull request Feb 5, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels enhancement:request Enhancement request submitted by anyone from the community lyft Related to Lyft v0.31 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants