Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make text in sunburst path more readable #675

Merged
merged 1 commit into from Jun 24, 2016
Merged

Make text in sunburst path more readable #675

merged 1 commit into from Jun 24, 2016

Conversation

mistercrunch
Copy link
Member

Make the text color be black or white based on lightness of background color.
screen shot 2016-06-24 at 8 44 11 am
@williaster @xrmx

superseeds https://github.com/airbnb/caravel/pull/674/files

@coveralls
Copy link

coveralls commented Jun 24, 2016 •
edited

Coverage Status

Coverage remained the same at 81.41% when pulling 6095c57 on mistercrunch:sunburst_readable into 1313727 on airbnb:master.

@mistercrunch mistercrunch merged commit 914f234 into apache:master Jun 24, 2016
@mistercrunch mistercrunch deleted the sunburst_readable branch June 24, 2016 19:28
@xrmx
Copy link
Contributor

xrmx commented Jun 24, 2016

Thanks!

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@rusackas @zhaoyongjie
chore: Cleaning up control overrides (apache#675)
ff4000e 
* fix: errant heatmap override

* fix: nixing lineMulti vestigial override

* nixing unused import!
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@rusackas @zhaoyongjie
chore: Cleaning up control overrides (apache#675)
01b88dc 
* fix: errant heatmap override

* fix: nixing lineMulti vestigial override

* nixing unused import!
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@rusackas @zhaoyongjie
chore: Cleaning up control overrides (apache#675)
a79da6c 
* fix: errant heatmap override

* fix: nixing lineMulti vestigial override

* nixing unused import!
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@rusackas @zhaoyongjie
chore: Cleaning up control overrides (apache#675)
d3bf534 
* fix: errant heatmap override

* fix: nixing lineMulti vestigial override

* nixing unused import!
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.10.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mistercrunch @coveralls @xrmx