Minor improvements to <Hotkeys /> component #7261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* left align, close to button it's related to * text-muted, so it's a bit more subtle * fix required func props, where no func it actually passed
mistercrunch
force-pushed
the
fix_hotkeys
branch
from
55feec4
to
bceca41
Compare
Codecov Report
@@ Coverage Diff @@
## master #7261 +/- ##
==========================================
- Coverage 64.72% 64.72% -0.01%
==========================================
Files 425 425
Lines 20672 20669 -3
Branches 2282 2283 +1
==========================================
- Hits 13380 13377 -3
Misses 7167 7167
Partials 125 125
Continue to review full report at Codecov.
|
|
LGTM |
hughhhh
approved these changes
Apr 11, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Screenshots
Before: React validation error