Add new escape characters to OnPasteSelect #7638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1AB9502
changed the title
1AB9502
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7638 +/- ##
=========================================
Coverage ? 65.57%
=========================================
Files ? 435
Lines ? 21754
Branches ? 2394
=========================================
Hits ? 14266
Misses ? 7367
Partials ? 121
Continue to review full report at Codecov.
|
|
Could you add some unit tests for this to |
|
@etr2460, totally missed! I updated unit tests to check for tabs and new line characters. |
mistercrunch
approved these changes
Jun 5, 2019
etr2460
reviewed
Jun 5, 2019
superset/assets/spec/javascripts/components/OnPasteSelect_spec.jsx
Outdated
Show resolved
Hide resolved
superset/assets/spec/javascripts/components/OnPasteSelect_spec.jsx
Outdated
Show resolved
Hide resolved
etr2460
approved these changes
Jun 6, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Our internal users love pasting stuff info filters from CSVs or excel docs.
Currently onPasteSelect only parses comma separated values. I added new line and tabs (you never know) to the separator array
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
In order to test the implementation I pasted the following values into the filter sections in the charts
regression test:
12345,45678,78906
new values tests
12345,
45678,
78906
12345
45678
78906
All values got parsed correctly
ADDITIONAL INFO
Duplicates closed pull request #7634 since I fudged something up in my local repo