Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow bigint to be used as time column in Presto" #7670 #7678

Merged
merged 1 commit into from Jun 10, 2019

Conversation

john-bodley
Copy link
Member

Per #7218 (comment) including a BIGINT column type as a time column in Presto is problematic as it could represent either a Unix time in seconds or milliseconds.

The current correct way to handle Unix time columns is to set the python_date_format as either epoch or epoch_ms (depending on the encoding) which results in queries comprising the correct fidelity:

SELECT COUNT(*) AS "count"
FROM "superset"."logs"
WHERE "dttm" >= 1553644800
  AND "dttm" <= 1554249600
ORDER BY "count" DESC
LIMIT 10000;

Note #7656 plans to auto-detect the encoding of temporal columns.

to: @betodealmeida @mistercrunch

@john-bodley
Copy link
Member Author

@mistercrunch this is a replacement to #7670 which was problematic after the split up of db_engine_specs.py.

@codecov-io
Copy link

Codecov Report

Merging #7678 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7678      +/-   ##
==========================================
+ Coverage   65.71%   65.71%   +<.01%     
==========================================
  Files         459      459              
  Lines       21873    21871       -2     
  Branches     2403     2403              
==========================================
  Hits        14373    14373              
+ Misses       7379     7377       -2     
  Partials      121      121
Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 69.71% <ø> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95291fa...375bc76. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jun 8, 2019

Codecov Report

Merging #7678 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7678      +/-   ##
==========================================
+ Coverage   65.71%   65.71%   +<.01%     
==========================================
  Files         459      459              
  Lines       21873    21871       -2     
  Branches     2403     2403              
==========================================
  Hits        14373    14373              
+ Misses       7379     7377       -2     
  Partials      121      121
Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 69.71% <ø> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95291fa...375bc76. Read the comment docs.

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit 49390b3 into apache:master Jun 10, 2019
@john-bodley john-bodley deleted the john-bodley--revert-7670 branch June 10, 2019 23:10
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants