css: add margin-top to ResultSet #7679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
commented
Jun 9, 2019
| @@ -73,6 +73,7 @@ export default class ResultSet extends React.PureComponent { | |||
| // when new results comes in, save them locally and clear in store | |||
| if (this.props.cache && (!nextProps.query.cached) | |||
| && nextProps.query.results | |||
| && nextProps.query.results.data | |||
There was a problem hiding this comment.
FYI: Unrelated bug I hit while doing CSS tweaks
etr2460
approved these changes
Jun 10, 2019
|
I thought about the tradeoffs of padding the tab-pane a little, and though maybe we wanted more density like for data tables/previews. Then I thought that we don't want left or right margins for the layout to align. I can to the conclusion that it's for the children to decide how they want to use the space. I'm no designer and don't know much about structuring CSS properly. Happy to take a different approach. |
|
That makes sense to me, thanks for the context! |
michellethomas
pushed a commit
that referenced
this pull request
Jun 24, 2019
(cherry picked from commit f278faa)
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit f278faa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
See images
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After