fix: multi deck.gl bug fixes #7854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add onViewportChange method to handle changes to the viewport
Codecov Report
@@ Coverage Diff @@
## master #7854 +/- ##
==========================================
- Coverage 65.8% 65.79% -0.02%
==========================================
Files 461 461
Lines 22090 22094 +4
Branches 2422 2423 +1
==========================================
Hits 14536 14536
- Misses 7433 7437 +4
Partials 121 121
Continue to review full report at Codecov.
|
- causes multi deck.gl to fail to render scatter without max_radius attribute
thunter009
changed the title
mistercrunch
approved these changes
Jul 12, 2019
alex-mark
pushed a commit
to alex-mark/incubator-superset
that referenced
this pull request
Jul 29, 2019
* fix: multi deck.gl viewport frozen add onViewportChange method to handle changes to the viewport * fix: add max_radius to deck.gl scatter example - causes multi deck.gl to fail to render scatter without max_radius attribute
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add onViewportChange method to handle changes to the viewport
CATEGORY
Choose one
SUMMARY
Multi deck.gl chart's are currently pretty broken. A few bug fixes to make more useable:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
visual inspection
ADDITIONAL INFORMATION
fixes: #7841
REVIEWERS