Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7130 - SQL Lab table name autocomplete #7926

Merged
merged 1 commit into from Jul 28, 2019

Conversation

mistercrunch
Copy link
Member

No description provided.

@request-info
Copy link

request-info bot commented Jul 26, 2019

We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the title or description empty.

@request-info request-info bot added the need:more-info Requires more information from author label Jul 26, 2019
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #7926 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7926   +/-   ##
=======================================
  Coverage   65.91%   65.91%           
=======================================
  Files         465      465           
  Lines       22268    22268           
  Branches     2429     2429           
=======================================
  Hits        14679    14679           
  Misses       7468     7468           
  Partials      121      121
Impacted Files Coverage Δ
.../assets/src/SqlLab/components/AceEditorWrapper.jsx 57.31% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb891dc...6af5bf2. Read the comment docs.

@mistercrunch mistercrunch merged commit 5f98d66 into apache:master Jul 28, 2019
@mistercrunch mistercrunch deleted the fix_autocomplete branch July 28, 2019 00:42
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:more-info Requires more information from author size/XS 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants