[feature flag] Enforce csrf protection on explore_json endpoint #7935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceguo-supercat
force-pushed
the
gg-DisableGETOnQueryRequest
branch
2 times, most recently
from
8e33b5b
to
45f11af
Compare
Codecov Report
@@ Coverage Diff @@
## master #7935 +/- ##
==========================================
+ Coverage 65.97% 65.97% +<.01%
==========================================
Files 468 468
Lines 22297 22304 +7
Branches 2429 2429
==========================================
+ Hits 14710 14715 +5
- Misses 7466 7468 +2
Partials 121 121
Continue to review full report at Codecov.
|
etr2460
approved these changes
Jul 29, 2019
| @@ -204,7 +204,8 @@ | |||
| # will result in combined feature flags of { 'FOO': True, 'BAR': True, 'BAZ': True } | |||
| DEFAULT_FEATURE_FLAGS = { | |||
| # Experimental feature introducing a client (browser) cache | |||
| "CLIENT_CACHE": False | |||
| "CLIENT_CACHE": False, | |||
| "ENABLE_EXPLORE_JSON_CSRF_PROTECTION": False, | |||
There was a problem hiding this comment.
Let's add a comment explaining this flag too?
graceguo-supercat
force-pushed
the
gg-DisableGETOnQueryRequest
branch
from
45f11af
to
85dc23b
Compare
also added a section for featured flags in http://superset.incubator.apache.org/installation.html
|
I added a section in http://superset.incubator.apache.org/installation.html for featured flags: |
graceguo-supercat
force-pushed
the
gg-DisableGETOnQueryRequest
branch
from
85dc23b
to
41d2305
Compare
3 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR is to resume the work in #7449. For some security concerns, we need to enforce CSRF protection on query request to
explore_jsonendpoint.So I want to add a new feature flag:
ENABLE_EXPLORE_JSON_CSRF_PROTECTION. WhenENABLE_EXPLORE_JSON_CSRF_PROTECTIONis set to true, user cannot make GET request toexplore_json.The default value for this feature
False(current behavior), explore_json accepts both GET and POST request.TEST PLAN
send GET request to
explore_json, you will get405 Method Not Allowedexception.REVIEWERS
@DiggidyDave @betodealmeida @john-bodley @mistercrunch