Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature flag for Presto expand data #8056

Merged
merged 4 commits into from Aug 16, 2019
Merged

Add feature flag for Presto expand data #8056

merged 4 commits into from Aug 16, 2019

Conversation

betodealmeida
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

@john-bodley found a Presto nested type that raises and error when querying, due to #7391. I've added the functionality behind a feature flag.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen Shot 2019-08-15 at 6 18 17 PM

After:

Screen Shot 2019-08-15 at 6 18 19 PM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@john-bodley @etr2460 @khtruong

@john-bodley
Copy link
Member

cc: @graceguo-supercat

@john-bodley
Copy link
Member

Thanks for the quick temporary fix.

@betodealmeida
Copy link
Member Author

I'll fix the tests and merge.

@betodealmeida betodealmeida merged commit 478d096 into apache:master Aug 16, 2019
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Aug 16, 2019
@betodealmeida
Add feature flag for Presto expand data (apache#8056)
ef8eb79 
* Add feature flag for Presto expand data

* Fix unit tests

* Fix black

* Revert temporary file change

(cherry picked from commit 478d096)
@graceguo-supercat graceguo-supercat mentioned this pull request Aug 16, 2019
Merged
6 tasks
@john-bodley
Copy link
Member

@betodealmeida I think we also need the feature check here as the get_columns method also calls _parse_structural_column.

@choupijiang choupijiang mentioned this pull request Sep 17, 2023
Open
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

@khtruong khtruong khtruong approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.35.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@betodealmeida @john-bodley @khtruong @mistercrunch