Handling NULL values in Filters #825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkalyan
changed the title
| @@ -177,7 +177,7 @@ def get_df(self, query_obj=None): | |||
| if self.datasource.offset: | |||
| df.timestamp += timedelta(hours=self.datasource.offset) | |||
| df.replace([np.inf, -np.inf], np.nan) | |||
| df = df.fillna(0) | |||
| df = df.fillna('NULL') | |||
There was a problem hiding this comment.
It seems like this main create some problems where there's missing data expected to be numeric. Ultimately we want javascript's reserved null in the json. Would df.fillna(None) work?
There was a problem hiding this comment.
df.fillna(None) threw an error 'must specify a fill method or value'
But I get your point - if ('NULL') is treated as true in javascript. we may need some similar handling in javascript (like value=='NULL'?value:null).
Side note - should this fillna be done only for Dimensions and skip Metrics ?
|
@mistercrunch I've been testing lot of visualizations with this fix, no issues are found. |
This was referenced Dec 19, 2020
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
After recent changes to chart controls in Superset, some typing has become obsolete. Let's clean it up.
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
After recent changes to chart controls in Superset, some typing has become obsolete. Let's clean it up.
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
After recent changes to chart controls in Superset, some typing has become obsolete. Let's clean it up.
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
After recent changes to chart controls in Superset, some typing has become obsolete. Let's clean it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, we can not add Filter to express that value of dimension is NULL.
Adding null in filterbox is considered for searching for literal string 'NULL'.
Addresses Issue: #663
Also displaying NULL values as NULL (instead of 0) as per @x4base suggestion.