Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to bind the webserver to a specific address #826

Merged
merged 1 commit into from
Jul 28, 2016
Merged

Allow to bind the webserver to a specific address #826

merged 1 commit into from
Jul 28, 2016

Conversation

plumbeo
Copy link
Contributor

@plumbeo plumbeo commented Jul 27, 2016

Add an option to allow users to choose to what IP address the web server must bind. Default to 0.0.0.0 (all IP addresses).

…ver must bind to. Default to 0.0.0.0 (all IP addresses).
@coveralls
Copy link

coveralls commented Jul 27, 2016

Coverage Status

Coverage increased (+0.01%) to 81.023% when pulling ee00db2 on plumbeo:bind-address into f43e5f1 on airbnb:master.

@xrmx
Copy link
Contributor

xrmx commented Jul 27, 2016

What about using -b as gunicorn does?

@plumbeo
Copy link
Contributor Author

plumbeo commented Jul 27, 2016

@xrmx I used -a because caravel already uses the -p flag to select the port while gunicorn uses -b to select both address and port at the same time, so I thought using the same flag with a different meaning would be confusing. I can change it, in case.

@xrmx
Copy link
Contributor

xrmx commented Jul 27, 2016

@plumbeo yeah, makes sense :)

@mistercrunch
Copy link
Member

LGTM

@mistercrunch mistercrunch merged commit 8872677 into apache:master Jul 28, 2016
@plumbeo plumbeo deleted the bind-address branch July 28, 2016 19:41
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants