[fix] Chart specific time controls #8674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
changed the title
john-bodley
force-pushed
the
john-bodley--chart-specific-time-grainularity
branch
from
79f3b6d
to
1a9d6a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #8674 +/- ##
==========================================
+ Coverage 65.4% 65.54% +0.14%
==========================================
Files 482 482
Lines 24083 24083
Branches 2763 2763
==========================================
+ Hits 15751 15786 +35
+ Misses 8152 8117 -35
Partials 180 180
Continue to review full report at Codecov.
|
etr2460
reviewed
Dec 4, 2019
| @@ -23,7 +23,7 @@ export const druidTimeSeries = { | |||
| label: t('Time'), | |||
| expanded: true, | |||
| description: t('Time related form attributes'), | |||
| controlSetRows: [['granularity', 'druid_time_origin'], ['time_range']], | |||
| controlSetRows: [['time_range']], | |||
There was a problem hiding this comment.
why did you remove both of these here but only one in sqla?
etr2460
approved these changes
Dec 4, 2019
| @@ -23,7 +23,7 @@ export const druidTimeSeries = { | |||
| label: t('Time'), | |||
| expanded: true, | |||
| description: t('Time related form attributes'), | |||
| controlSetRows: [['granularity', 'druid_time_origin'], ['time_range']], | |||
| controlSetRows: [['time_range']], | |||
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Dec 4, 2019
(cherry picked from commit 38782e2)
This was referenced Dec 5, 2019
12 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR ensures that only the relevant time widgets are included depending on the chart type. Previously the granularity logic was shown even if the chart type did not support granularity, i.e., non-timeseries charts.
This provides a number of benefits including:
Additionally this PR also removes the time controls for chart types which don't support time filtering, i.e., iFrame, Markup, etc.
Note erroneous form-data fields are removed on load in explorer but will persist in database until the slice is re-saved.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TEST PLAN
CI.
ADDITIONAL INFORMATION
REVIEWERS
to: @etr2460 @graceguo-supercat @michellethomas @mistercrunch @willbarrett @villebro