[dashboard] new, bulk actions for delete & export #8979

nytai · 2020-01-16T18:51:22Z

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

unit tested
manual testing

ADDITIONAL INFORMATION

REVIEWERS

codecov-io · 2020-01-18T02:03:28Z

Codecov Report

Merging #8979 into master will increase coverage by 0.35%.
The diff coverage is 86.59%.

@@            Coverage Diff             @@
##           master    #8979      +/-   ##
==========================================
+ Coverage   59.16%   59.52%   +0.35%     
==========================================
  Files         367      369       +2     
  Lines       11679    11738      +59     
  Branches     2862     2880      +18     
==========================================
+ Hits         6910     6987      +77     
+ Misses       4590     4572      -18     
  Partials      179      179

Impacted Files	Coverage Δ
...assets/src/components/ListView/TableCollection.tsx	`92.59% <ø> (ø)`	⬆️
...et/assets/src/components/IndeterminateCheckbox.jsx	`100% <100%> (ø)`
...perset/assets/src/components/ListView/ListView.tsx	`92.1% <100%> (+0.92%)`	⬆️
superset/assets/src/components/ListView/utils.ts	`98.46% <100%> (+0.31%)`	⬆️
...t/assets/src/views/dashboardList/DashboardList.tsx	`82.4% <64.51%> (+23.46%)`	⬆️
...rset/assets/src/components/ConfirmStatusChange.tsx	`90% <90%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7415869...2d58aa6. Read the comment docs.

dpgaspar · 2020-01-21T15:47:57Z

superset/assets/spec/javascripts/components/ConfirmStatusChange_spec.jsx

+describe('ConfirmStatusChange', () => {
+  const action = jest.fn();
+  const mockedProps = {
+    title: 'please confirm',


t('please confirm') ?

This is just a test, so raw string should be ok.

suddjian · 2020-01-22T01:07:08Z

superset/assets/src/components/ConfirmStatusChange.tsx

+const defaultCallback = () => { console.error('ConfirmStatusChange invoked with the default callback, please provide a function to be called on confirm'); };
+export default class ConfirmStatusChange extends React.Component<Props, State> {
+
+  public state = {


This and other methods that are only used in this class should probably not be marked public

good point. It was tslint --fix that added them and i should have probably done a second pass.

looks like typescript is complaining about that. React.PureComponet and React.Component both expose state as a public property.

suddjian · 2020-01-22T01:19:04Z

superset/assets/src/components/ConfirmStatusChange.tsx

+    open: false,
+  };
+
+  public show: ShowCallback = (callback) => (event) => {


I think it would make more sense to pass the callback as a prop to the <ConfirmStatusChange> component. The callback isn't really "state" as far as I can tell, and it could be misleading to think that you can call show multiple times, when that will actually break things.

The callback is held in the closure state until the event triggers at which point it's put into the components state and the modal pops up. Holding the callback in state only happens when the modal is open and we're just waiting for user confirmation before executing the original function. Show can be called multiple times with different callbacks and each callback won't be placed into the state until right before they're about to be executed/cancel (via the modal). Since only one modal can be open at a time I think this makes sense.

What isn't configurable is the message displayed to the user, so that does limit the number of confirmation prompts this can be used with. Passing the title and description to show may make sense to enable multiple confirmation messages.

Oh, I see. I stand corrected. I'm still a little confused by this though. What's the advantage of a stateful setup like this instead of using a separate ConfirmStatusChange for each action that needs confirmation, and passing the callback in as a prop?

Good point. I had modal reuse in mind when I was writing it, but that kind of fell apart once I had to use it in the actions cell renderer. I'll change it, you're right, it's less confusing to pass stuff as props.

suddjian · 2020-01-22T01:20:30Z

superset/assets/src/views/dashboardList/DashboardList.tsx

+        }
+
+        return (
+          <ConfirmStatusChange title={t('Please Confirm')} description={`${t('Are you sure you want to delete')} ${original.dashboard_title}?`}>


This <ConfirmStatusChange> could wrap just the delete button instead of the entire collection of buttons.

suddjian · 2020-01-23T01:38:22Z

superset/assets/src/components/ConfirmStatusChange.tsx

    this.setState({
-      callback: () => callback(event),
+      callbackArgs,


If the callback args is supposed to be the DOM event, this will not work as intended. Events can't be referenced asynchronously. https://reactjs.org/docs/events.html#event-pooling

You'd need to check if the arg is an Event, and call .persist() on it.

Good catch, I was cloning it before. None of my current use cases rely on the dom event, but probably best to handle that to avoid future weirdness.

suddjian

LGTM

I like the hooks and good job DRYing things up!

superset-github-bot bot added the preset-io label Jan 16, 2020

pull-request-size bot added the size/XL label Jan 16, 2020

nytai changed the title ~~Tai/bulk actions~~ bulk actions for dashboard list view Jan 16, 2020

nytai force-pushed the tai/bulk-actions branch 2 times, most recently from 8f4c785 to 5c960ef Compare January 18, 2020 01:52

dpgaspar reviewed Jan 21, 2020

View reviewed changes

pull-request-size bot added size/XXL and removed size/XL labels Jan 21, 2020

nytai force-pushed the tai/bulk-actions branch from 71f7165 to 2d58aa6 Compare January 21, 2020 18:55

nytai added 10 commits January 21, 2020 14:16

bulk actions for dashboards list view

b874200

add confirm component

2a8d73a

finish bulk actions work

4c58f74

remove loading component

217464a

fix sortby double render bug, lint, fix specs

1d81af3

adds spec for bulk actions

8d637f3

fix spec

f94e635

spec ConfirmStatusChange

f2d4bab

lint

6bb1918

tslint

2c1a9fd

nytai force-pushed the tai/bulk-actions branch from 2d58aa6 to 2c1a9fd Compare January 21, 2020 23:35

nytai marked this pull request as ready for review January 21, 2020 23:36

nytai changed the title ~~bulk actions for dashboard list view~~ [dashboard] new, bulk actions for delete & export Jan 21, 2020

suddjian reviewed Jan 22, 2020

View reviewed changes

nytai added 2 commits January 22, 2020 16:41

address review feedback

796c74e

tslint fixes

a0a9428

nytai requested review from dpgaspar and mistercrunch January 23, 2020 01:09

suddjian reviewed Jan 23, 2020

View reviewed changes

guard against empty filterTypes

936cdf7

nytai mentioned this pull request Jan 23, 2020

[chart] new, list view (react) #8999

Merged

12 tasks

nytai added 2 commits January 23, 2020 10:37

persist dom events

d103cc5

tslint

54a10f5

suddjian approved these changes Jan 24, 2020

View reviewed changes

mistercrunch merged commit a0cda32 into apache:master Jan 27, 2020

mistercrunch deleted the tai/bulk-actions branch January 27, 2020 18:23

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dashboard] new, bulk actions for delete & export #8979

[dashboard] new, bulk actions for delete & export #8979

nytai commented Jan 16, 2020 •

edited

codecov-io commented Jan 18, 2020 •

edited

dpgaspar Jan 21, 2020

nytai Jan 21, 2020

suddjian Jan 22, 2020

nytai Jan 22, 2020

nytai Jan 22, 2020 •

edited

suddjian Jan 22, 2020

suddjian Jan 22, 2020

nytai Jan 22, 2020

suddjian Jan 22, 2020 •

edited

nytai Jan 22, 2020

suddjian Jan 22, 2020

suddjian Jan 23, 2020

suddjian Jan 23, 2020

nytai Jan 23, 2020

suddjian left a comment

[dashboard] new, bulk actions for delete & export #8979

[dashboard] new, bulk actions for delete & export #8979

Conversation

nytai commented Jan 16, 2020 • edited

CATEGORY

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

REVIEWERS

codecov-io commented Jan 18, 2020 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nytai Jan 22, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

suddjian Jan 22, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

suddjian left a comment

Choose a reason for hiding this comment

nytai commented Jan 16, 2020 •

edited

codecov-io commented Jan 18, 2020 •

edited

nytai Jan 22, 2020 •

edited

suddjian Jan 22, 2020 •

edited