Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[log] fix, log model view permissions #8993

Merged
merged 6 commits into from
Jan 26, 2020
Merged

[log] fix, log model view permissions #8993

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b8d001
[log] Only Admin's have log model view permissions
dpgaspar Jan 22, 2020
7935c61
[log] test security change
dpgaspar Jan 22, 2020
8422472
Merge remote-tracking branch 'upstream/master' into fix/log-view-perm…
dpgaspar Jan 23, 2020
19addb0
Merge remote-tracking branch 'upstream/master' into fix/api-superset-…
dpgaspar Jan 23, 2020
f6305f9
[log] Limit log REST API methods
dpgaspar Jan 24, 2020
2e4f4c7
[log] more tests
dpgaspar Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions superset/security/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ class SupersetSecurityManager(SecurityManager):
"Refresh Druid Metadata",
"ResetPasswordView",
"RoleModelView",
"LogModelView",
"Security",
} | USER_MODEL_VIEWS

Expand Down
13 changes: 9 additions & 4 deletions tests/security_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,11 +579,16 @@ def test_is_admin_only(self):
)
)

self.assertTrue(
security_manager._is_admin_only(
security_manager.find_permission_view_menu("can_delete", "DatabaseView")
log_permissions = ["can_list", "can_show"]
for log_permission in log_permissions:
self.assertTrue(
security_manager._is_admin_only(
security_manager.find_permission_view_menu(
log_permission, "LogModelView"
)
)
)
)

if app.config["ENABLE_ACCESS_REQUEST"]:
self.assertTrue(
security_manager._is_admin_only(
Expand Down