Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[logging] Add flag for document visibility #9070

Merged
merged 1 commit into from Feb 3, 2020
Merged

[logging] Add flag for document visibility #9070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions superset/assets/src/middleware/loggerMiddleware.js
View file
Open in desktop
Expand Up @@ -107,6 +107,7 @@ const loggerMiddleware = store => next => action => {
...eventData,
event_type: 'user',
event_id: lastEventId,
visibility: document.visibilityState,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move this into the top level eventData so that it's added on timing events too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timing event (mostly is data loading and chart render) is triggered by user event (dashboard mount, switch tab, etc). I assume during 1 user event (a few charts will be loading and re-render), the browser's visibilityState will not change.

};
}

Expand Down