Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts] Fix, double registration of charts API #9134

Merged
merged 2 commits into from Feb 14, 2020
Merged

[charts] Fix, double registration of charts API #9134

merged 2 commits into from Feb 14, 2020

Conversation

dpgaspar
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Was causing no impact but it's an error, Chart API is already being registered on app.py

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

villebro
villebro approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got me thinking, would it be possible to log a warning or even an exception if the same api is added twice?

nytai
nytai approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for adding functionality (most likely in FAB) warning that a resource was registered more than once.

@dpgaspar
Copy link
Member Author

Totally @villebro and @nytai

@dpgaspar dpgaspar merged commit 1aab4c0 into apache:master Feb 14, 2020
@dpgaspar dpgaspar deleted the fix/chart-api-registration branch February 14, 2020 08:46
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbarrett willbarrett willbarrett approved these changes

@nytai nytai nytai approved these changes

@villebro villebro villebro approved these changes

@craig-rueda craig-rueda Awaiting requested review from craig-rueda

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dpgaspar @willbarrett @nytai @villebro @mistercrunch