-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[database] Fix, tables endpoint #9144
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
931ea55
[database] Fix, tables endpoint
dpgaspar e2ad7ab
merge and fix conflicts
dpgaspar 26a0f8e
[datasets] lint and DRYing
dpgaspar eaa6e70
[datasets] fix JS tests
dpgaspar f1f78f1
[datasets] override openapi spec tag
dpgaspar e5fa701
[database] more tests
dpgaspar fb08c85
[database] Fix, invalid database id call on old API
dpgaspar 63f4f00
[database] lints and types
dpgaspar 91223a5
Merge branch 'master' into fix/superset-tables-api
dpgaspar f1993ea
[database] lint
dpgaspar 215a606
[database] Address comments
dpgaspar ac6a8f4
Refactor to two PRs
dpgaspar 88e3f7e
Refactor to two PRs
dpgaspar abccf95
Refactor to two PRs
dpgaspar File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we settle for try-except with
.one()
or.one_or_none()
withif not
? I'm fine either way, just prefer to have it as uniform as possible in the codebase.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a majority of
one_or_none()
oncore.py