Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-36] deprecate tslint and configure eslint for typescript #9172

Merged
merged 1 commit into from Feb 20, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Feb 20, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This PR deprecates tslint and configures eslint for typescript files. Using @airbnb/nimbus would be preferable as a long term goal, however that library is poorly documented and I had trouble getting it to work with our current setup. I left the WIP on a branch https://github.com/preset-io/incubator-superset/tree/tai/eslint-ts if anyone more familiar with integratin nimbus into existing projects would like to pick it up. For now this gets rid of tslint (and it's overly strict rules) which should make it easier to transition to typescript.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

  • linting works

ADDITIONAL INFORMATION

REVIEWERS

@etr2460 @suddjian @rusackas

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming CI runs and everything's still functional after the autofixes

this is amazing, it looks like this is a good first step towards modernizing our linting setup. i'm glad to be rid of tslint!

@nytai nytai marked this pull request as ready for review February 20, 2020 02:47
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clap

@etr2460
Copy link
Member

etr2460 commented Feb 20, 2020

I'm going to merge this in then! Thanks @nytai, maybe @kristw can help you set up Nimbus in a future PR

@etr2460 etr2460 merged commit 74423e5 into apache:master Feb 20, 2020
@rusackas rusackas deleted the tai/ts-eslint branch June 18, 2021 16:54
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate tslint in favor of eslint w/ typescript support
4 participants