Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [explore] don't save filters inherited from a dashboard #9340

Merged
merged 2 commits into from
Mar 24, 2020

Commits on Mar 23, 2020

  1. feat: [explore] don't save filters inherited from a dashboard

    When navigating to explore from a dashboard context, the current
    dashboard filter(s) are passed along to explore so that the context is
    kept. So say you're filtering on "country=Romania", in your dashboard
    and pivot to explore, that filter is still there and keep on exploring.
    
    Now a common issue is that you'll want to make some tweak to your chart
    that are unrelated to the filter, say toggling the legend off for
    instance, and then save it. Now you back to your dashboard and even
    though you started with an "all countries" dashboard, with a global
    filter on country, now that one chart is stuck on "Romania". Typically
    you notice this when filtering on something else, say "Italy" and then
    that one chart now has two mutually exclusive filters, and show "No data".
    
    Now, the fix is to flag the filter as "extra" (that's the not-so-good internal
    name we use for these inherited filters) and make it clear that that
    specific filter is special and won't be saved when saving the chart.
    mistercrunch committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    2dac019 View commit details
    Browse the repository at this point in the history
  2. fix build

    mistercrunch committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    935a46b View commit details
    Browse the repository at this point in the history