Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYNCOPE-798 now cancel does logout #13

Closed
wants to merge 3 commits into from
Closed

SYNCOPE-798 now cancel does logout #13

wants to merge 3 commits into from

Conversation

suinfreedom
Copy link

No description provided.

@suinfreedom
Copy link
Author

Pr is completed, now you can take a look.

@@ -0,0 +1,63 @@
/*
* Copyright 2016 The Apache Software Foundation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad license header: take a look at other Java files in the same package.

@ilgrosso
Copy link
Member

ilgrosso commented May 2, 2016

Hi @mteo thanks for your PR!
There are few minor comments of mine: once fixed, I'll be happy to merge it.

@suinfreedom
Copy link
Author

Hi @ilgrosso,
I made the changes. Thanks for the review.

@ilgrosso
Copy link
Member

ilgrosso commented May 2, 2016

LGTM @mteo I'll go ahead and merge, thanks!

@suinfreedom suinfreedom closed this May 2, 2016
@suinfreedom suinfreedom deleted the SYNCOPE-798 branch May 2, 2016 15:38
danilo-dellorco added a commit to danilo-dellorco/syncope that referenced this pull request Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants