Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping year to 2020 #179

Merged
merged 3 commits into from
May 1, 2020
Merged

Bumping year to 2020 #179

merged 3 commits into from
May 1, 2020

Conversation

coheigea
Copy link
Contributor

@coheigea coheigea commented May 1, 2020

No description provided.

@ilgrosso
Copy link
Member

ilgrosso commented May 1, 2020

@coheigea thanks for reporting this!

There are, however, several NOTICE files in the source tree that should be amended as well.

Moreover, we'll need to do the same with branches 2_1_X and 2_0_X

@coheigea
Copy link
Contributor Author

coheigea commented May 1, 2020

@ilgrosso I updated the PR to pick up the other NOTICE files

Copy link
Member

@ilgrosso ilgrosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks again!

Are you going to take care of other two branches mentioned above as well?

@ilgrosso
Copy link
Member

ilgrosso commented May 1, 2020

@coheigea by looking at other years' similar commits I found the following file should be updated as well: src/site/site.xml

Copy link
Member

@ilgrosso ilgrosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/site/site.xml is missing

@coheigea
Copy link
Contributor Author

coheigea commented May 1, 2020

@ilgrosso Done! Could you backport to the older branches?

@ilgrosso ilgrosso merged commit 7d86cbf into apache:master May 1, 2020
@ilgrosso
Copy link
Member

ilgrosso commented May 1, 2020

@coheigea sure

ilgrosso pushed a commit that referenced this pull request May 1, 2020
ilgrosso pushed a commit that referenced this pull request May 1, 2020
@coheigea coheigea deleted the NOTICE branch May 1, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants