Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOJIRA - Turn off bean proxying for WA; fixes typo #290

Merged
merged 1 commit into from
Sep 19, 2021
Merged

NOJIRA - Turn off bean proxying for WA; fixes typo #290

merged 1 commit into from
Sep 19, 2021

Conversation

mmoayyed
Copy link
Contributor

This pull request turns off and disables CGLIB bean proxying for the WA module. This is the recommended practice from Spring which would help WA in the future to compile better and easier against GraalVM. Without bean proxying, bean methods can no longer call each other directly during construction, as there is no proxy to intercept. Instead, references either need to be passed as auto-wired parameters (the approach used here), or they need to be injected into configuration classes using injections. (The latter approach is generally more preferable, if the number of injected parameters grows unwieldy)

Also fixes a bean name typo (missing e).

This approach might also be used for #287 as well.

@ilgrosso
Copy link
Member

Thanks for providing these very useful background information: without knowing exactly the context, I am already taking this approach in #287 , maybe not everywhere yet.

@mmoayyed mmoayyed merged commit cc1dd72 into apache:master Sep 19, 2021
@mmoayyed mmoayyed deleted the bean-proxying branch September 19, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants