Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYNCOPE-1680: support Simple MFA for WA #348

Merged
merged 26 commits into from
May 31, 2022
Merged

SYNCOPE-1680: support Simple MFA for WA #348

merged 26 commits into from
May 31, 2022

Conversation

mmoayyed
Copy link
Contributor

@mmoayyed mmoayyed commented May 31, 2022

See https://issues.apache.org/jira/browse/SYNCOPE-1680

A few things to note:

  • WA is only tasked to manage "CAS"-owned settings. Simple MFA typically requires additional configuration (such as managing the email server setup) that are handled by Spring and Spring Boot, as part of "spring.mail.*" settings. Those need to be managed separately in property files, etc.

A more precise view of the changes can be seen here: https://github.com/apache/syncope/compare/master...mmoayyed:SYNCOPE-1680?w=1

image

image

@mmoayyed mmoayyed marked this pull request as ready for review May 31, 2022 08:51
@mmoayyed
Copy link
Contributor Author

@mdisabatino Could you take a look and let me know if this works for you?

@mmoayyed mmoayyed requested a review from mdisabatino May 31, 2022 08:52
@ilgrosso
Copy link
Member

ilgrosso commented May 31, 2022

@mmoayyed a question: what is the expected value of bypassGroovyScript? A path or the actual script content?

Nice to see how Console is leveraging bean reflection to build UI, BTW :-)

@mmoayyed
Copy link
Contributor Author

Yes indeed, I was pleasantly surprised to see the UI pick up all relevant settings. Very nice!

To your question: the script setting is a path to a Groovy script that would evaluate bypass rules. It ultimately maps to this, as an example:

cas.authn.mfa.simple.bypass.groovy.location=file:${CAS_CONF_DIRECTORY}/mfaSimpleTrigger.groovy

@mmoayyed mmoayyed merged commit f2f5819 into apache:master May 31, 2022
@mmoayyed mmoayyed deleted the SYNCOPE-1680 branch May 31, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants