[SYNCOPE-1665] show error on propagation failure, made some refactoring #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgrosso
requested changes
Jul 24, 2022
There was a problem hiding this comment.
I appreciate the overall idea, but, besides the changes already requested, I think it would be useful to:
- add two properties (not one) as of
reportPropagationErrorsandreportPropagtionErrorDetails: the former will just enable the propagation error reporting with a generic message as 'Something went wrong during propagation, contact your administrator', while the latter will allow to explore the actual error per Resource - definitely improve UI
client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/commons/RESTUtils.java
Outdated
Show resolved
Hide resolved
...epo/enduser/src/main/java/org/apache/syncope/client/enduser/commons/PageParametersUtils.java
Outdated
Show resolved
Hide resolved
...er/src/main/resources/org/apache/syncope/client/enduser/SyncopeEnduserApplication.properties
Show resolved
Hide resolved
.../enduser/src/main/resources/org/apache/syncope/client/enduser/pages/SelfResult_ja.properties
Outdated
Show resolved
Hide resolved
.../enduser/src/main/resources/org/apache/syncope/client/enduser/pages/SelfResult_ru.properties
Outdated
Show resolved
Hide resolved
andrea-patricelli
force-pushed
the
SYNCOPE-1665
branch
from
c93dce0
to
c46ab48
Compare
ilgrosso
requested changes
Sep 9, 2022
client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...common-ui/src/main/java/org/apache/syncope/client/ui/commons/panels/SimpleListViewPanel.java
Fixed
Show resolved
Hide resolved
ilgrosso
approved these changes
Sep 10, 2022
andrea-patricelli
force-pushed
the
SYNCOPE-1665
branch
from
cf428ca
to
9fd0fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.