Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYNCOPE-1737] Managing releaseAttrs via DefaultAttrReleasePolicyConf #418

Merged
merged 4 commits into from
Mar 3, 2023
Merged

[SYNCOPE-1737] Managing releaseAttrs via DefaultAttrReleasePolicyConf #418

merged 4 commits into from
Mar 3, 2023

Conversation

ilgrosso
Copy link
Member

@ilgrosso ilgrosso commented Mar 2, 2023

…ePolicyConf

@ilgrosso ilgrosso changed the title [SYNCOPE-1737] Adding and managing releaseAttrs via DefaultAttrReleas… [SYNCOPE-1737] Adding and managing releaseAttrs via DefaultAttrReleasePolicyConf Mar 2, 2023
@ilgrosso ilgrosso changed the title [SYNCOPE-1737] Adding and managing releaseAttrs via DefaultAttrReleasePolicyConf [SYNCOPE-1737] Managing releaseAttrs via DefaultAttrReleasePolicyConf Mar 2, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 2, 2023
View reviewed changes
wa/starter/src/main/java/org/apache/syncope/wa/starter/mapping/OIDCRPClientAppTOMapper.java
} else if (attributeReleasePolicy instanceof ReturnAllowedAttributeReleasePolicy) {
customClaims.addAll(((ReturnAllowedAttributeReleasePolicy) attributeReleasePolicy).
getAllowedAttributes().stream().collect(Collectors.toSet()));
} else if (attributeReleasePolicy instanceof ChainingAttributeReleasePolicy) {

Check failure

Code scanning / CodeQL

Contradictory type checks

This access of [attributeReleasePolicy](1) cannot be of type [ChainingAttributeReleasePolicy](2), since [this expression](3) ensures that it is not of type [ChainingAttributeReleasePolicy](2).
wa/starter/src/main/java/org/apache/syncope/wa/starter/mapping/OIDCRPClientAppTOMapper.java
customClaims.addAll(((ReturnAllowedAttributeReleasePolicy) attributeReleasePolicy).
getAllowedAttributes().stream().collect(Collectors.toSet()));
} else if (attributeReleasePolicy instanceof ChainingAttributeReleasePolicy) {
((ChainingAttributeReleasePolicy) attributeReleasePolicy).getPolicies().stream().

Check failure

Code scanning / CodeQL

Contradictory type checks

This access of [attributeReleasePolicy](1) cannot be of type [ChainingAttributeReleasePolicy](2), since [this expression](3) ensures that it is not of type [ChainingAttributeReleasePolicy](2).
.../am/lib/src/main/java/org/apache/syncope/common/lib/policy/DefaultAttrReleasePolicyConf.java
@@ -119,6 +123,10 @@

private final PrincipalAttrRepoConf principalAttrRepoConf = new PrincipalAttrRepoConf();

public Map<String, Object> getReleaseAttrs() {

Check notice

Code scanning / CodeQL

Exposing internal representation

getReleaseAttrs exposes the internal representation stored in field releaseAttrs. The value may be modified [after this call to getReleaseAttrs](1). getReleaseAttrs exposes the internal representation stored in field releaseAttrs. The value may be modified [after this call to getReleaseAttrs](2). getReleaseAttrs exposes the internal representation stored in field releaseAttrs. The value may be modified [after this call to getReleaseAttrs](3).
@ilgrosso ilgrosso merged commit e2e12a9 into apache:3_0_X Mar 3, 2023
@ilgrosso ilgrosso deleted the SYNCOPE-1737 branch March 3, 2023 12:59
ilgrosso added a commit to ilgrosso/syncope that referenced this pull request Mar 3, 2023
@ilgrosso
[SYNCOPE-1737] Managing releaseAttrs via DefaultAttrReleasePolicyConf (…
b3484f1 
…apache#418)
ilgrosso added a commit that referenced this pull request Mar 4, 2023
@ilgrosso
[SYNCOPE-1737] Managing releaseAttrs via DefaultAttrReleasePolicyConf (…
b506bcd 
…#418)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ilgrosso