[SYSTEMDS-2925] Federated left indexing #1219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaOvcharenko
changed the title
Baunsgaard
reviewed
Apr 14, 2021
| if(in1.isFederated(FederationMap.FType.ROW) && (to = (prev + ren - rsn)) >= 0 && | ||
| to < in2.getNumRows() && ixrange.rowStart <= re) { | ||
| sliceIxs[i] = new int[] { prev, (int) to, 0, (int) in2.getNumColumns()-1}; | ||
| prev = (int) (to + 1); |
There was a problem hiding this comment.
something has gone wrong with the indentation
| instStrings[i] = modifyIndices(newIx, 4, 8); | ||
| ranges[i] = range; | ||
| from = Math.min(i, from); | ||
| } else |
There was a problem hiding this comment.
code style specifies newline before else after a }
There was a problem hiding this comment.
Thanks for the review, fixed the formatting now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds federated left indexing, the simplest case when rhs matrix or frame is read and broadcast sliced (e.g. A[2:12, 3:4] = B).