Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYSTEMDS-3272] setSchema built-in to set the schema of frame from DML #1504

Closed
wants to merge 1 commit into from
Closed

[SYSTEMDS-3272] setSchema built-in to set the schema of frame from DML #1504

wants to merge 1 commit into from

Conversation

Shafaq-Siddiqi
Copy link
Contributor

  • This built-in will allow changing the schema of a frame inside DML
  • Function call is placed inside detectSchema test

@Shafaq-Siddiqi
[SYSTEMDS-3272] setSchema built-in to set the schema of frame from DML
3a287df 
  - This built-in will allow to change the schema of a frame inside DML
@phaniarnab
Copy link
Contributor

Thanks for this extension @Shafaq-Siddiqi.
This crashes because FP32 and INT32 are missing in the exact serialized size calculation logic (FrameBlock.java::getExactSerializedSize()).
I will investigate it further.

@Baunsgaard
Copy link
Contributor

Thanks for this extension @Shafaq-Siddiqi. This crashes because FP32 and INT32 are missing in the exact serialized size calculation logic (FrameBlock.java::getExactSerializedSize()). I will investigate it further.

This sounds related to the Bug just fixed in de3b970

@Baunsgaard
Copy link
Contributor

Is this PR no longer relevant?

@phaniarnab
Copy link
Contributor

Nope. It is a duplicate. Safe to close.

@j143 j143 closed this Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phaniarnab phaniarnab Awaiting requested review from phaniarnab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Shafaq-Siddiqi @phaniarnab @Baunsgaard @j143