[SYSTEMDS-3185] Worker-specific Multithreading of Operations #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - thanks for the patch @ywcb00. This is a nice, generic way of handling degree of parallelism at the federated workers. Before merging it in, I'd like to understand why the Python tests are now failing in this and other PRs but not on main. |
|
Python test failed because when reading in a file for some reason we to import Apache commons-compress and that is not available in our bin release. The only place where we have automated the testing of our bin release is in Python. We should add a test of our normal system that use our bin release. See 336ac8b for fix. |
|
ok thanks for the clarification. |
…rs with a stored number of threads chore(**Operator.java): make the operators with a number of threads to subclasses of the MultiThreadedOperator remove the separate members for the number of threads feat(FederatedWorkerHandler.java): replace the number of threads of the multi threaded operator with the number of processors on the federated site
ywcb00
force-pushed
the
feat/fed/multitenancy/optimize/instructionparallelization
branch
from
f80eff1
to
31e144d
Compare
|
LGTM again, and sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds the MultiThreadedOperator class as a superclass for all operators supporting multithreading. This allows us to replace the number of threads of the operator with a worker-specific amount after parsing the received instruction from the EXEC_INST request.
With this PR, we are setting the number of threads to the amount of processors available to the JVM of the federated worker whenever the operator allows for multithreading (i.e. a subclass of MultiThreadedOperator).
Thanks for review :)