[SYSTEMDS-2102] Vectorize gradients for Factorization Machines function #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
j143
commented
Apr 7, 2023
j143
commented
CP°fcall°./nn/layers/fm.dml°backward°true°5°3°dout=_mVar779·MATRIX·FP64°X=X_batch·MATRIX·FP64°w0=w0·MATRIX·FP64°W=W·MATRIX·FP64°V=V·MATRIX·FP64°dw0°dW°dV
|
the code doesn't seem to be correct: -- old g_V2 -- -- g_V2 -- |
|
LGTM but remove the commented code. |
|
Hi @Baunsgaard - thanks for review. I believe the vectorization I made is incorrect, especially output dimensions. |
aww sad, it looked good at a surface glance, maybe we do not have enough tests ? |
|
We verify the with gradients at the moment. but, we need to verify against R implementation once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.