Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYSTEMDS-3695] Fix frame builtin nary append for Spark backend #2026

Closed
wants to merge 1 commit into from

Conversation

e-strauss
Copy link
Contributor

This patch implements the nary append operation for frames (cbind and rbind). For the cbind, there are two physical implementation:

  • map-size cbind (w/ broadcast)
  • reduce-size cbind
    I added test cases to check the functionality of the n-ary operators and I also enabled the Word-Error-Rate test case.

Additionally, this patch fixes the map-size cbind operation to handle misaligned frameblocks.
As discussed, I will make another PR for the misalignment fix of the other physical operator

@mboehm7
Copy link
Contributor

mboehm7 commented Jun 3, 2024

LGTM - thanks for the patch @e-strauss. During the merge I only fixes minor warnings and formatting issues.

@mboehm7 mboehm7 closed this in 7d1f081 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants