This repository has been archived by the owner on May 12, 2021. It is now read-only.
TAJO-2166: Disallow csv file format in DDL Languages #1037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjinleekr
force-pushed
the
feature/TAJO-2166
branch
2 times, most recently
from
a51583a
to
9a5b065
Compare
dongjinleekr
force-pushed
the
feature/TAJO-2166
branch
from
9a5b065
to
ddb6f98
Compare
| executeString("CREATE TABLE D1.table1 (age int) using csv;").close(); | ||
| fail("It should not reach here."); | ||
| } catch (Throwable e) { | ||
| assertEquals(e.getClass(), SQLSyntaxError.class); |
There was a problem hiding this comment.
How about using JUnit's Expected Exception? You can simply check the expected exception like in https://github.com/apache/tajo/blob/master/tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalogExceptions.java#L65,
or do more things like described here https://github.com/junit-team/junit4/wiki/Exception-testing.
…sage for using csv storage type.
|
I applied all your comments! :) |
|
+1 Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.