This repository has been archived by the owner on May 12, 2021. It is now read-only.
TAJO-1480: Kafka Consumer for kafka strage. #1041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually package name is lower case.
| static final String TEST_JSON_DATA = "{\"col1\":1, \"col2\":\"abc\", \"col3\":0.2}"; | ||
| static final int DEFAULT_TEST_PARTITION_NUM = 3; | ||
|
|
||
| static void sendTestData(Producer<String, String> producer, String topic) throws Exception { |
There was a problem hiding this comment.
This class name is constants but you defined method in the class.
|
Thanks you for your contribution! I left trivial comment |
| @@ -0,0 +1,195 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
You should add tajo-storage-kafk module to tajo-storage and add module copy-script in prepare-package
Cause TestConstants class has the methods even Constants class.
combineads
force-pushed
the
TAJO-1480
branch
2 times, most recently
from
221e084
to
6b0ea6a
Compare
|
@jinossy Thanks for your reviews. I modified sources. |
in prepare-package.
|
+1 Looks great to me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scanner of kafka storage needs to implement a Kafka Consumer for to fetch data from kafka.
The Kafka Consumer have methods like this,