This repository has been archived by the owner on May 12, 2021. It is now read-only.
TAJO-1241: Change default client and table time zone behavior. #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into TAJO-1238
…into TAJO-1238
…into TZ_BUG Conflicts: tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-client/src/main/proto/ClientProtos.proto tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestSetSessionQuery.java tajo-core/src/test/resources/results/TestSQLAnalyzer/settimezone1.result tajo-core/src/test/resources/results/TestSQLAnalyzer/settimezone2.result tajo-core/src/test/resources/results/TestSQLAnalyzer/settimezone3.result
…into TAJO-1241
| throw new RuntimeException("No such session variable" + varname); | ||
| void updateSessionVarsCache(Map<String, String> variables) { | ||
| synchronized (sessionVarsCache) { | ||
| this.sessionVarsCache.clear(); |
There was a problem hiding this comment.
I wonder why all cached variables are cleared before update.
Whenever a set command is executed, a new hash map instance is passed from the client.
(Please see SetCommand.updateSessionVariable().)
There was a problem hiding this comment.
This is because we use synchronized feature against sessionVarsCache. In this case, if we replace the object by another object, the synchronization will not work correctly. It will cause some concurrency problem.
|
Hi @hyunsik, |
|
+1! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, TajoClient uses GMT as client time zone unless session variable TIMEZONE is specified. Also, by default Table uses GMT as table time zone unless table property timezone is specified.
This patch changes these default behavior as follows:
TimeZone.getDefault()by default.tajo.timezoneof TajoConf by default.I also added the documentation about time zone.