TAJO-20: INSERT INTO ... SELECT #72

babokim · 2014-07-14T07:30:01Z

No description provided.

…into TAJO-20 Conflicts: tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java

hyunsik · 2014-07-15T07:06:52Z

tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java

@@ -43,6 +51,17 @@
  protected final int [] keyIds;
  protected final String [] keyNames;

+  static final ThreadLocal<NumberFormat> OUTPUT_FILE_FORMAT_SEQ =


It seems to be not used.

hyunsik · 2014-07-15T08:32:05Z

+1

In overall, the patch looks nice to me, and it includes nice unit tests. I also verified 'mvn clean install'.

Before commiting it, I'll do as follows:

add more comments to new implemented methods
rename the unit test method that I pointed out
removed unused static variable

ZEPPELIN-122 prevent add resource more than twice in a same connection

김형준 and others added 3 commits June 4, 2014 18:22

TAJO-20: INSERT INTO ... SELECT

8598110

TAJO-20: INSERT INTO ... SELECT

fd9397c

hyunsik reviewed Jul 15, 2014
View reviewed changes

asfgit closed this in 499d108 Jul 15, 2014

babokim pushed a commit to babokim/tajo that referenced this pull request Dec 11, 2014

Merge pull request apache#72 from NFLabs/fix_hive_add_resource

7b01b37

ZEPPELIN-122 prevent add resource more than twice in a same connection

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TAJO-20: INSERT INTO ... SELECT #72

TAJO-20: INSERT INTO ... SELECT #72

babokim commented Jul 14, 2014

hyunsik Jul 15, 2014

hyunsik commented Jul 15, 2014

TAJO-20: INSERT INTO ... SELECT #72

TAJO-20: INSERT INTO ... SELECT #72

Conversation

babokim commented Jul 14, 2014

hyunsik Jul 15, 2014

Choose a reason for hiding this comment

hyunsik commented Jul 15, 2014