-
Notifications
You must be signed in to change notification settings - Fork 113
TAJO-2064: Supporting auto-completion in Tsql #955
Conversation
Sorry for late review. I'll finish to review this PR in a few days. |
Never mind. |
If you implement |
Good, I've done. |
} | ||
|
||
private Collection<String> getKeywords() { | ||
List<String> klist = new ArrayList<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a ambiguous name. How about rename it to keywords
or keywordList
?
} | ||
} | ||
|
||
class ConfCompleter extends StringsCompleter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, many tajo inner-classes have been declared inside their top-class. How about put ConfCompleter
inside TajoGetConfCommand
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a good suggestion.
@blrunner |
Thanks for your reflection. Well, I have one more suggestion. Currently, Tajo provides a SQL grammar file as following: But if we have existing grammar file and |
@blrunner |
+1 Sorry for late review. |
Use tab key in Tsql