Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4289: Remove Dependency on commons-math #110

Merged
merged 3 commits into from
Feb 17, 2021

Conversation

belugabehr
Copy link
Contributor

No description provided.

@belugabehr
Copy link
Contributor Author

Everything looks good here, but getting a weird build error. Not sure what to make of it:

[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc (default-cli) on project tez-javadoc-tools: An error has occurred in Javadoc report generation: 
[ERROR] Exit code: 1 - /home/jenkins/jenkins-agent/workspace/tez-multibranch_PR-110/src/tez-tools/tez-javadoc-tools/src/main/java/org/apache/tez/tools/javadoc/doclet/ConfigStandardDoclet.java:36: warning: [removal] AnnotationDesc in com.sun.javadoc has been deprecated and marked for removal
[ERROR] import com.sun.javadoc.AnnotationDesc.ElementValuePair;
[ERROR]                       ^
[ERROR] /home/jenkins/jenkins-agent/workspace/tez-multibranch_PR-110/src/tez-tools/tez-javadoc-tools/src/main/java/org/apache/tez/tools/javadoc/doclet/ConfigStandardDoclet.java:42: error: package com.sun.tools.doclets.standard is not visible
[ERROR] import com.sun.tools.doclets.standard.Standard;
[ERROR]                             ^
[ERROR]   (package com.sun.tools.doclets.standard is declared in module jdk.javadoc, which does not export it)

@jteagles
Copy link
Contributor

I think jdk 11 build was enabled today. @abstractdog can you verify? If so, I think we will need fix from
https://issues.apache.org/jira/browse/TEZ-4025

@abstractdog
Copy link
Contributor

abstractdog commented Feb 13, 2021

I think jdk 11 build was enabled today. @abstractdog can you verify? If so, I think we will need fix from
https://issues.apache.org/jira/browse/TEZ-4025

yes, I think javadoc jdk11 issues should be ignored now and in the near future, while we figure out and merge a fix for that

@belugabehr
Copy link
Contributor Author

@abstractdog Not sure what's up this time. Seem to be getting a 404 error on the continuous-integration/jenkins/pr-merge. Any thoughts?

@belugabehr
Copy link
Contributor Author

@jteagles @abstractdog last test run passed, but results were only published to JIRA and not to Github. Please consider for merge.

https://issues.apache.org/jira/browse/TEZ-4289?focusedCommentId=17286075&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17286075

@jteagles
Copy link
Contributor

+1. Think this is good.

@jteagles jteagles merged commit 70623f0 into apache:master Feb 17, 2021
asfgit pushed a commit that referenced this pull request Feb 17, 2021
* TEZ-4289: Remove Dependency on commons-math

* Remove stray reference to commons-math

* Fix checkstyle and missing parenthesis

(cherry picked from commit 70623f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants