TEZ-4412 ensure mkDirForAM create directory with special permissions #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi @abstractdog ,I found some permission issue here, can you please take a look? |
|
thanks for the patch @skysiders! |
abstractdog
requested changes
May 7, 2022
| fs.mkdirs(dir, new FsPermission(TEZ_AM_DIR_PERMISSION)); | ||
| FsPermission perm = new FsPermission(TEZ_AM_DIR_PERMISSION); | ||
| fs.mkdirs(dir, perm); | ||
| if(!fs.getFileStatus(dir).getPermission().equals(perm)){ |
There was a problem hiding this comment.
this method is public static, looks easily testable, could you please introduce a unit test in TestTezCommonUtils?
There was a problem hiding this comment.
Thanks for your review. I will check it.
There was a problem hiding this comment.
Hi @abstractdog ,I add UT and fix check style. Couldyou please take a look?
This comment was marked as outdated.
This comment was marked as outdated.
Hi @abstractdog , I'm sorry to make mistake in UT, and I try to fix it in this patch. |
|
🎊 +1 overall
This message was automatically generated. |
|
thanks @skysiders , there is 1 more checkstyle issue reported |
|
Thanks for your review @abstractdog , I use checkstyle:check find issue in |
|
🎊 +1 overall
This message was automatically generated. |
abstractdog
reviewed
May 9, 2022
| Configuration remoteConf = new Configuration(); | ||
| remoteConf.set(MiniDFSCluster.HDFS_MINIDFS_BASEDIR, TEST_ROOT_DIR); | ||
| remoteConf.set(CommonConfigurationKeys.FS_PERMISSIONS_UMASK_KEY, "777"); | ||
| MiniDFSCluster miniDFS = new MiniDFSCluster.Builder(remoteConf).numDataNodes(3).format(true).racks(null) |
There was a problem hiding this comment.
unit test works as expected, this patch is so close, 1 more thing, could you please shutdown miniDFS cluster?
There was a problem hiding this comment.
Hi @abstractdog .Thanks for your suggestion, In this patch, I closed miniDFS after I ran out of it. Thank you for reviewing my code, it has taught me a lot.
There was a problem hiding this comment.
merged to master, thanks @skysiders for this patch, your tireless work, and quick responses!
|
🎊 +1 overall
This message was automatically generated. |
abstractdog
approved these changes
May 10, 2022
asfgit
pushed a commit
that referenced
this pull request
May 10, 2022
…209) (Zhang Dongsheng reviewed by Laszlo Bodor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEZ-4412 ensure mkDirForAM create directory with special permissions
I found TezClientUtils has method ensureStagingDirExists.It will check whether the path "stagingArea" exists, if it exists, check the permission, if not, call the function "TezCommonUtils.mkDirForAM" to create.But in method mkDirForAM,it use mkdir(path, permission) to create, if umask too strict such as 777,this directory will set with 000 permission.So we need to ensure the directory has right permission.
In this patch, I compared the permissions of the files with the expected permissions. If they are inconsistent, then log this and use setPermission to grant directory permissions.